Fix typos and outdated info in Konfig guide #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Mikhail Zholobov <legal90@gmail.com>
legal90
force-pushed
the
fix-konfig-guide
branch
from
30c114d to
5c04c9c
Compare
Signed-off-by: Mikhail Zholobov <legal90@gmail.com>
Signed-off-by: Mikhail Zholobov <legal90@gmail.com>
legal90
force-pushed
the
fix-konfig-guide
branch
from
5c04c9c to
419433e
Compare
Contributor
Author
|
@Peefy, thanks for merging this PR! But the actual rendered version of the website still contains the old data: https://www.kcl-lang.io/docs/user_docs/guides/working-with-konfig/guide Though, the "next" version is shown correctly, with this fix included: https://www.kcl-lang.io/docs/next/user_docs/guides/working-with-konfig/guide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
docs/user_docs/guides/working-with-konfig/*3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
This PRs updates code examples and snippets according to the latest changes in
kcl-lang/konfigrepo, especially this: kcl-lang/konfig#314. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links: